First installment of flex fcst with ELR and pycpt#590
Open
remicousin wants to merge 1 commit intomasterfrom
Open
First installment of flex fcst with ELR and pycpt#590remicousin wants to merge 1 commit intomasterfrom
remicousin wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aaron-kaplan this is an FYI in case you want to check on some things.
@xchourio I know I made the case for small PRs, but when starting up, it's always a bit difficult.
This is about setting up a ccsr section of the python maprooms with for now one maproom (flex_fcst) that does IRI ELR flex fcst Maprooms. Namely exactly this:
https://iridl.ldeo.columbia.edu/maproom/Global/Forecasts/NMME_Seasonal_Forecasts/precip_full.html
It's using the work done in enacts/flex_fcst and preserves the case to use the app for a pycpt forecast. And it's using pepsico maproom/layout utilities.
So most of the work was to:
-- adapt enacts/flex_fcst to pepsico utils
-- adapt it to take either pycpt or ELR forecast
There's default and IRI config to run the ELR Maproom and a test-pycpt config to check that it still works with that. Then pycpt.py and iri_fd_elr.py contain the specific of reading and computing for these 2 cases. flex_fcast_calc.py is used by maproom.py to interface between the 2 cases. Everything else comes from either enacts/flex_fcst or pepsico, and adapted if needed.
There is no rush on this work so feel free to take your time to review.
Known problems / next steps to resolve in smaller incremental PRs: